Fix size check for QUIC_HANDSHAKE_INFO#5219
Merged
Merged
Conversation
Size checks on QUIC_HANDSHAKE_INFO need to take into account backward compatibility, as some prior versions were a shorter length. Quictls and schannel account for this but openssl does not. Fix that up Fixes microsoft#5217
guhetier
approved these changes
Jul 2, 2025
guhetier
left a comment
guhetier
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the PR.
Ideally, we should add a test to validate we don't regress this in the future (or onboard OpenSSL to our test passes, I can't remember right now if it has been done?)
Contributor
Author
|
@guhetier It has, or at least its part of the CI. There may be missing test cases I'm unaware of however |
Collaborator
Good to know, thanks! We might have to follow up to add a test case for querying the TLS params with various buffer sizes in that case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Size checks on QUIC_HANDSHAKE_INFO need to take into account backward compatibility, as some prior versions were a shorter length. Quictls and schannel account for this but openssl does not.
Fix that up
Fixes #5217